Repository navigation
Conversation
Collaborator
Author
|
pyrefly now crashes with "Stdlib missing class |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Removing it is probably the wrong approach as primer shows, and since we're likely just going to ignore that error code anyway. But I'll try something different. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Let's wait for #16587, which should help with the primer hits. |
_IOBase.read() and write() into functions
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
marked this pull request as ready for review
October 28, 2026 20:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally introduced in #4912, because the docs say:
In the PR I said:
This now seems to be the case, since ty 0.0.87 not very unreasonably complains in sub-classes (see #16551):
Since the interface may vary according to the docs, I'm not sure how useful there fields are in any case. Let's first see what primer says.